Unverified Commit 11cd7a5c authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

regulator: tps65219: regulator: tps65219: Fix error codes in probe() 



There is a copy and paste error and we accidentally use "PTR_ERR(rdev)"
instead of "error".  The "rdev" pointer is valid at this point.

Also there is no need to print the error code in the error message
because dev_err_probe() already prints that.  So clean up the error
message a bit.

Fixes: 38c9f98d ("regulator: tps65219: Add support for TPS65215 Regulator IRQs")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aKRGmVdbvT1HBvm8@stanley.mountain


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 447be505

drivers/regulator/tps65219-regulator.c

+6 −6
Original line number Diff line number Diff line
@@ -454,9 +454,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev) 
						  irq_type->irq_name,

						  irq_data);

		if (error)

			return dev_err_probe(tps->dev, PTR_ERR(rdev),

					     "Failed to request %s IRQ %d: %d\n",

					     irq_type->irq_name, irq, error);

			return dev_err_probe(tps->dev, error,

					     "Failed to request %s IRQ %d\n",

					     irq_type->irq_name, irq);

	}



	for (i = 0; i < pmic->dev_irq_size; ++i) {
@@ -477,9 +477,9 @@ static int tps65219_regulator_probe(struct platform_device *pdev) 
						  irq_type->irq_name,

						  irq_data);

		if (error)

			return dev_err_probe(tps->dev, PTR_ERR(rdev),

					     "Failed to request %s IRQ %d: %d\n",

					     irq_type->irq_name, irq, error);

			return dev_err_probe(tps->dev, error,

					     "Failed to request %s IRQ %d\n",

					     irq_type->irq_name, irq);

	}



	return 0;