Commit 11e298f3 authored by Shyam Sundar S K's avatar Shyam Sundar S K Committed by Hans de Goede
Browse files

platform/x86/amd/pmf: Fix TEE enact command failure after suspend and resume 



TEE enact command failures are seen after each suspend/resume cycle;
fix this by cancelling the policy builder workqueue before going into
suspend and reschedule the workqueue after resume.

[  629.516792] ccp 0000:c2:00.2: tee: command 0x5 timed out, disabling PSP
[  629.516835] amd-pmf AMDI0102:00: TEE enact cmd failed. err: ffff000e, ret:0
[  630.550464] amd-pmf AMDI0102:00: AMD_PMF_REGISTER_RESPONSE:1
[  630.550511] amd-pmf AMDI0102:00: AMD_PMF_REGISTER_ARGUMENT:7
[  630.550548] amd-pmf AMDI0102:00: AMD_PMF_REGISTER_MESSAGE:16

Fixes: ae82cef7 ("platform/x86/amd/pmf: Add support for PMF-TA interaction")
Co-developed-by: default avatarPatil Rajesh Reddy <Patil.Reddy@amd.com>
Signed-off-by: default avatarPatil Rajesh Reddy <Patil.Reddy@amd.com>
Signed-off-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20240216064112.962582-2-Shyam-sundar.S-k@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 3da01394

drivers/platform/x86/amd/pmf/core.c

+6 −0
Original line number Diff line number Diff line
@@ -296,6 +296,9 @@ static int amd_pmf_suspend_handler(struct device *dev) 
{

	struct amd_pmf_dev *pdev = dev_get_drvdata(dev);



	if (pdev->smart_pc_enabled)

		cancel_delayed_work_sync(&pdev->pb_work);



	kfree(pdev->buf);



	return 0;
@@ -312,6 +315,9 @@ static int amd_pmf_resume_handler(struct device *dev) 
			return ret;

	}



	if (pdev->smart_pc_enabled)

		schedule_delayed_work(&pdev->pb_work, msecs_to_jiffies(2000));



	return 0;

}