Unverified Commit 11f74f48 authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Fix uninitialized pointer error in probe() 



If pcim_request_all_regions() fails, error path operates on
uninitialized 'bus' pointer. Found out by Coverity static analyzer.

Reviewed-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250730124906.351798-1-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8d452acc

sound/soc/intel/avs/core.c

+2 −1
Original line number Diff line number Diff line
@@ -445,6 +445,8 @@ static int avs_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) 
	adev = devm_kzalloc(dev, sizeof(*adev), GFP_KERNEL);

	if (!adev)

		return -ENOMEM;

	bus = &adev->base.core;



	ret = avs_bus_init(adev, pci, id);

	if (ret < 0) {

		dev_err(dev, "failed to init avs bus: %d\n", ret);
@@ -455,7 +457,6 @@ static int avs_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) 
	if (ret < 0)

		return ret;



	bus = &adev->base.core;

	bus->addr = pci_resource_start(pci, 0);

	bus->remap_addr = pci_ioremap_bar(pci, 0);

	if (!bus->remap_addr) {