Unverified Commit 121f3434 authored by Björn Töpel's avatar Björn Töpel Committed by Palmer Dabbelt
Browse files

riscv: Replace function-like macro by static inline function 



The flush_icache_range() function is implemented as a "function-like
macro with unused parameters", which can result in "unused variables"
warnings.

Replace the macro with a static inline function, as advised by
Documentation/process/coding-style.rst.

Fixes: 08f051ed ("RISC-V: Flush I$ when making a dirty page executable")
Signed-off-by: default avatarBjörn Töpel <bjorn@rivosinc.com>
Link: https://lore.kernel.org/r/20250419111402.1660267-1-bjorn@kernel.org


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent 9c32cda4

arch/riscv/include/asm/cacheflush.h

+10 −5
Original line number Diff line number Diff line
@@ -34,11 +34,6 @@ static inline void flush_dcache_page(struct page *page) 
	flush_dcache_folio(page_folio(page));

}



/*

 * RISC-V doesn't have an instruction to flush parts of the instruction cache,

 * so instead we just flush the whole thing.

 */

#define flush_icache_range(start, end) flush_icache_all()

#define flush_icache_user_page(vma, pg, addr, len)	\

do {							\

	if (vma->vm_flags & VM_EXEC)			\
@@ -78,6 +73,16 @@ void flush_icache_mm(struct mm_struct *mm, bool local); 


#endif /* CONFIG_SMP */



/*

 * RISC-V doesn't have an instruction to flush parts of the instruction cache,

 * so instead we just flush the whole thing.

 */

#define flush_icache_range flush_icache_range

static inline void flush_icache_range(unsigned long start, unsigned long end)

{

	flush_icache_all();

}



extern unsigned int riscv_cbom_block_size;

extern unsigned int riscv_cboz_block_size;

void riscv_init_cbo_blocksizes(void);