Commit 122381a4 authored by Mateusz Guzik's avatar Mateusz Guzik Committed by Christian Brauner
Browse files

vfs: use RCU in ilookup 

A soft lockup in ilookup was reported when stress-testing a 512-way
system [1] (see [2] for full context) and it was verified that not
taking the lock shifts issues back to mm.

[1] https://lore.kernel.org/linux-mm/56865e57-c250-44da-9713-cf1404595bcc@amd.com/
[2] https://lore.kernel.org/linux-mm/d2841226-e27b-4d3d-a578-63587a3aa4f3@amd.com/



Signed-off-by: default avatarMateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20240715071324.265879-1-mjguzik@gmail.com


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 641bb439

fs/inode.c

+1 −3
Original line number Diff line number Diff line
@@ -1570,9 +1570,7 @@ struct inode *ilookup(struct super_block *sb, unsigned long ino) 
	struct hlist_head *head = inode_hashtable + hash(sb, ino);

	struct inode *inode;

again:

	spin_lock(&inode_hash_lock);

	inode = find_inode_fast(sb, head, ino, true);

	spin_unlock(&inode_hash_lock);

	inode = find_inode_fast(sb, head, ino, false);



	if (inode) {

		if (IS_ERR(inode))