Commit 122f6387 authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

ublk: don't access ublk_queue in ublk_need_complete_req() 



For ublk servers with many ublk queues, accessing the ublk_queue in
ublk_need_complete_req() is a frequent cache miss. Get the flags from
the ublk_device instead, which is accessed earlier in
ublk_ch_uring_cmd_local().

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent be7962d7

drivers/block/ublk_drv.c

+3 −3
Original line number Diff line number Diff line
@@ -2267,10 +2267,10 @@ static int ublk_check_commit_and_fetch(const struct ublk_device *ub, 
	return 0;

}



static bool ublk_need_complete_req(const struct ublk_queue *ubq,

static bool ublk_need_complete_req(const struct ublk_device *ub,

				   struct ublk_io *io)

{

	if (ublk_need_req_ref(ubq))

	if (ublk_dev_need_req_ref(ub))

		return ublk_sub_req_ref(io);

	return true;

}
@@ -2387,7 +2387,7 @@ static int ublk_ch_uring_cmd_local(struct io_uring_cmd *cmd, 
		io->res = result;

		req = ublk_fill_io_cmd(io, cmd);

		ret = ublk_config_io_buf(ub, io, cmd, addr, &buf_idx);

		compl = ublk_need_complete_req(ubq, io);

		compl = ublk_need_complete_req(ub, io);



		/* can't touch 'ublk_io' any more */

		if (buf_idx != UBLK_INVALID_BUF_IDX)