Commit 1234810b authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: net-drv: queues: sanity check netlink dumps 



This test already catches a netlink bug fixed by this series,
but only when running on HW with many queues. Make sure the
netdevsim instance created has a lot of queues, and constrain
the size of the recv_buffer used by netlink.

While at it test both rx and tx queues.

Reviewed-by: default avatarJoe Damato <jdamato@fastly.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/20241213152244.3080955-5-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 05188634

tools/testing/selftests/drivers/net/queues.py

+13 −10
Original line number Diff line number Diff line
@@ -8,24 +8,27 @@ from lib.py import cmd 
import glob





def sys_get_queues(ifname) -> int:

    folders = glob.glob(f'/sys/class/net/{ifname}/queues/rx-*')

def sys_get_queues(ifname, qtype='rx') -> int:

    folders = glob.glob(f'/sys/class/net/{ifname}/queues/{qtype}-*')

    return len(folders)





def nl_get_queues(cfg, nl):

def nl_get_queues(cfg, nl, qtype='rx'):

    queues = nl.queue_get({'ifindex': cfg.ifindex}, dump=True)

    if queues:

        return len([q for q in queues if q['type'] == 'rx'])

        return len([q for q in queues if q['type'] == qtype])

    return None





def get_queues(cfg, nl) -> None:

    queues = nl_get_queues(cfg, nl)

    snl = NetdevFamily(recv_size=4096)



    for qtype in ['rx', 'tx']:

        queues = nl_get_queues(cfg, snl, qtype)

        if not queues:

            raise KsftSkipEx('queue-get not supported by device')



    expected = sys_get_queues(cfg.dev['ifname'])

        expected = sys_get_queues(cfg.dev['ifname'], qtype)

        ksft_eq(queues, expected)
@@ -57,7 +60,7 @@ def addremove_queues(cfg, nl) -> None: 




def main() -> None:

    with NetDrvEnv(__file__, queue_count=3) as cfg:

    with NetDrvEnv(__file__, queue_count=100) as cfg:

        ksft_run([get_queues, addremove_queues], args=(cfg, NetdevFamily()))

    ksft_exit()