Commit 123a1750 authored by Mario Limonciello's avatar Mario Limonciello Committed by Alex Deucher
Browse files

drm/amd: Use dynamic array size declaration for amdgpu_connector_add_common_modes() 



[Why]
Adding or removing a mode from common_modes[] can be fragile if a user
forgot to update the for loop boundaries.

[How]
Use ARRAY_SIZE() to detect size of the array and use that instead.

Cc: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarTimur Kristóf <timur.kristof@gmail.com>
Link: https://lore.kernel.org/r/20250924161624.1975819-4-mario.limonciello@amd.com


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1f721ebc

drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c

+5 −2
Original line number Diff line number Diff line
@@ -398,10 +398,11 @@ static void amdgpu_connector_add_common_modes(struct drm_encoder *encoder, 
	struct drm_display_mode *mode = NULL;

	struct drm_display_mode *native_mode = &amdgpu_encoder->native_mode;

	int i;

	int n;

	static const struct mode_size {

		int w;

		int h;

	} common_modes[17] = {

	} common_modes[] = {

		{ 640,  480},

		{ 720,  480},

		{ 800,  600},
@@ -421,7 +422,9 @@ static void amdgpu_connector_add_common_modes(struct drm_encoder *encoder, 
		{1920, 1200}

	};



	for (i = 0; i < 17; i++) {

	n = ARRAY_SIZE(common_modes);



	for (i = 0; i < n; i++) {

		if (amdgpu_encoder->devices & (ATOM_DEVICE_TV_SUPPORT)) {

			if (common_modes[i].w > 1024 ||

			    common_modes[i].h > 768)