Commit 123bcf28 authored by Suren Baghdasaryan's avatar Suren Baghdasaryan Committed by Andrew Morton
Browse files

alloc_tag: use release_pages() in the cleanup path 

Patch series "Minor fixes for memory allocation profiling", v2.

Over the last couple months I gathered a few reports of minor issues in
memory allocation profiling which are addressed in this patchset.


This patch (of 2):

When bulk-freeing an array of pages use release_pages() instead of freeing
them page-by-page.

Link: https://lkml.kernel.org/r/20250915212756.3998938-1-surenb@google.com
Link: https://lkml.kernel.org/r/20250915212756.3998938-2-surenb@google.com


Signed-off-by: default avatarSuren Baghdasaryan <surenb@google.com>
Suggested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Suggested-by: default avatarUsama Arif <usamaarif642@gmail.com>
Acked-by: default avatarShakeel Butt <shakeel.butt@linux.dev>
Acked-by: default avatarUsama Arif <usamaarif642@gmail.com>
Cc: David Wang <00107082@163.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Sourav Panda <souravpanda@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 5919f128

lib/alloc_tag.c

+5 −5
Original line number Diff line number Diff line
@@ -438,9 +438,10 @@ static int vm_module_tags_populate(void) 
		if (nr < more_pages ||

		    vmap_pages_range(phys_end, phys_end + (nr << PAGE_SHIFT), PAGE_KERNEL,

				     next_page, PAGE_SHIFT) < 0) {

			release_pages_arg arg = { .pages = next_page };



			/* Clean up and error out */

			for (int i = 0; i < nr; i++)

				__free_page(next_page[i]);

			release_pages(arg, nr);

			return -ENOMEM;

		}
@@ -682,11 +683,10 @@ static int __init alloc_mod_tags_mem(void) 


static void __init free_mod_tags_mem(void)

{

	int i;

	release_pages_arg arg = { .pages = vm_module_tags->pages };



	module_tags.start_addr = 0;

	for (i = 0; i < vm_module_tags->nr_pages; i++)

		__free_page(vm_module_tags->pages[i]);

	release_pages(arg, vm_module_tags->nr_pages);

	kfree(vm_module_tags->pages);

	free_vm_area(vm_module_tags);

}