Unverified Commit 124af086 authored by Yongpeng Yang's avatar Yongpeng Yang Committed by Christian Brauner
Browse files

xfs: check the return value of sb_min_blocksize() in xfs_fs_fill_super 



sb_min_blocksize() may return 0. Check its return value to avoid the
filesystem super block when sb->s_blocksize is 0.

Cc: stable@vger.kernel.org # v6.15
Fixes: a64e5a59 ("bdev: add back PAGE_SIZE block size validation for sb_set_blocksize()")
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarYongpeng Yang <yangyongpeng@xiaomi.com>
Link: https://patch.msgid.link/20251104125009.2111925-5-yangyongpeng.storage@gmail.com


Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent e106e269

fs/xfs/xfs_super.c

+4 −1
Original line number Diff line number Diff line
@@ -1662,7 +1662,10 @@ xfs_fs_fill_super( 
	if (error)

		return error;



	sb_min_blocksize(sb, BBSIZE);

	if (!sb_min_blocksize(sb, BBSIZE)) {

		xfs_err(mp, "unable to set blocksize");

		return -EINVAL;

	}

	sb->s_xattr = xfs_xattr_handlers;

	sb->s_export_op = &xfs_export_operations;

#ifdef CONFIG_XFS_QUOTA