Commit 12651687 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Johannes Berg
Browse files

wifi: wlcore: Remove unused wl12xx_cmd_start_fwlog 



wl12xx_cmd_start_fwlog() was added in 2011 by
commit 95dac04f ("wl12xx: Support routing FW logs to the host")
but has remained unused.

Remove it.

(I can see the 'stop' is used, and the 'config' is used, so I assume
the 'start' isn't normally needed).

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20250622232638.166283-1-linux@treblig.org


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 6f3ec182

drivers/net/wireless/ti/wlcore/cmd.c

+0 −26
Original line number Diff line number Diff line
@@ -1804,32 +1804,6 @@ int wl12xx_cmd_config_fwlog(struct wl1271 *wl) 
	return ret;

}



int wl12xx_cmd_start_fwlog(struct wl1271 *wl)

{

	struct wl12xx_cmd_start_fwlog *cmd;

	int ret = 0;



	wl1271_debug(DEBUG_CMD, "cmd start firmware logger");



	cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);

	if (!cmd) {

		ret = -ENOMEM;

		goto out;

	}



	ret = wl1271_cmd_send(wl, CMD_START_FWLOGGER, cmd, sizeof(*cmd), 0);

	if (ret < 0) {

		wl1271_error("failed to send start firmware logger command");

		goto out_free;

	}



out_free:

	kfree(cmd);



out:

	return ret;

}



int wl12xx_cmd_stop_fwlog(struct wl1271 *wl)

{

	struct wl12xx_cmd_stop_fwlog *cmd;

drivers/net/wireless/ti/wlcore/cmd.h

+0 −1
Original line number Diff line number Diff line
@@ -81,7 +81,6 @@ int wlcore_cmd_regdomain_config_locked(struct wl1271 *wl); 
int wlcore_cmd_generic_cfg(struct wl1271 *wl, struct wl12xx_vif *wlvif,

			   u8 feature, u8 enable, u8 value);

int wl12xx_cmd_config_fwlog(struct wl1271 *wl);

int wl12xx_cmd_start_fwlog(struct wl1271 *wl);

int wl12xx_cmd_stop_fwlog(struct wl1271 *wl);

int wl12xx_cmd_channel_switch(struct wl1271 *wl,

			      struct wl12xx_vif *wlvif,