Commit 127367ad authored by Ethan Tidmore's avatar Ethan Tidmore Committed by Chen-Yu Tsai
Browse files

drm/sun4i: Fix resource leaks 



Three clocks are not being released in devm_regmap_init_mmio() error
path.

Add proper goto and set ret to the error code.

Fixes: 8270249f ("drm/sun4i: backend: Create regmap after access is possible")
Signed-off-by: default avatarEthan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Link: https://patch.msgid.link/20260226163836.10335-1-ethantidmore06@gmail.com


Signed-off-by: default avatarChen-Yu Tsai <wens@kernel.org>
parent 4037c6ad

drivers/gpu/drm/sun4i/sun4i_backend.c

+2 −1
Original line number Diff line number Diff line
@@ -881,7 +881,8 @@ static int sun4i_backend_bind(struct device *dev, struct device *master, 
						     &sun4i_backend_regmap_config);

	if (IS_ERR(backend->engine.regs)) {

		dev_err(dev, "Couldn't create the backend regmap\n");

		return PTR_ERR(backend->engine.regs);

		ret = PTR_ERR(backend->engine.regs);

		goto err_disable_ram_clk;

	}



	list_add_tail(&backend->engine.list, &drv->engine_list);