Commit 12cab119 authored by Deepakkumar Karn's avatar Deepakkumar Karn Committed by Paolo Abeni
Browse files

net: usb: rtl8150: fix memory leak on usb_submit_urb() failure 



In async_set_registers(), when usb_submit_urb() fails, the allocated
  async_req structure and URB are not freed, causing a memory leak.

  The completion callback async_set_reg_cb() is responsible for freeing
  these allocations, but it is only called after the URB is successfully
  submitted and completes (successfully or with error). If submission
  fails, the callback never runs and the memory is leaked.

  Fix this by freeing both the URB and the request structure in the error
  path when usb_submit_urb() fails.

Reported-by: default avatar <syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=8dd915c7cb0490fc8c52


Fixes: 4d12997a ("drivers: net: usb: rtl8150: concurrent URB bugfix")
Signed-off-by: default avatarDeepakkumar Karn <dkarn@redhat.com>
Link: https://patch.msgid.link/20251216151304.59865-2-dkarn@redhat.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent dff94bc6

drivers/net/usb/rtl8150.c

+2 −0
Original line number Diff line number Diff line
@@ -211,6 +211,8 @@ static int async_set_registers(rtl8150_t *dev, u16 indx, u16 size, u16 reg) 
		if (res == -ENODEV)

			netif_device_detach(dev->netdev);

		dev_err(&dev->udev->dev, "%s failed with %d\n", __func__, res);

		kfree(req);

		usb_free_urb(async_urb);

	}

	return res;

}