Commit 12d82c7b authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Takashi Iwai
Browse files

ALSA: hda: cs35l56: Remove redundant call to hda_cs_dsp_control_remove() 



The driver doesn't create any ALSA controls for firmware controls, so it
shouldn't be calling hda_cs_dsp_control_remove().

commit 34e1b1bb ("ALSA: hda: cs35l56: Stop creating ALSA controls for
firmware coefficients") removed the call to hda_cs_dsp_add_controls() but
didn't remove the call for destroying those controls.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 34e1b1bb ("ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients")
Link: https://patch.msgid.link/20240813110750.2814-1-rf@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 3beddef8

sound/pci/hda/cs35l56_hda.c

+1 −1
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ static void cs35l56_hda_remove_controls(struct cs35l56_hda *cs35l56) 
}



static const struct cs_dsp_client_ops cs35l56_hda_client_ops = {

	.control_remove = hda_cs_dsp_control_remove,

	/* cs_dsp requires the client to provide this even if it is empty */

};



static int cs35l56_hda_request_firmware_file(struct cs35l56_hda *cs35l56,