Commit 12eb22a5 authored by Ilya Dryomov's avatar Ilya Dryomov
Browse files

ceph: validate snapdirname option length when mounting 



It becomes a path component, so it shouldn't exceed NAME_MAX
characters.  This was hardened in commit c152737b ("ceph: Use
strscpy() instead of strcpy() in __get_snap_name()"), but no actual
check was put in place.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
Reviewed-by: default avatarAlex Markuze <amarkuze@redhat.com>
parent 550f7ca9

fs/ceph/super.c

+2 −0
Original line number Diff line number Diff line
@@ -431,6 +431,8 @@ static int ceph_parse_mount_param(struct fs_context *fc, 


	switch (token) {

	case Opt_snapdirname:

		if (strlen(param->string) > NAME_MAX)

			return invalfc(fc, "snapdirname too long");

		kfree(fsopt->snapdir_name);

		fsopt->snapdir_name = param->string;

		param->string = NULL;