Commit 12fa1fd6 authored by Pengpeng Hou's avatar Pengpeng Hou Committed by Alex Deucher
Browse files

drm/amd/display: bios_parser: fix GPIO I2C line off-by-one 



get_gpio_i2c_info() computes the number of GPIO I2C assignment records
present in the BIOS table and then uses bfI2C_LineMux as an array index
into header->asGPIO_Info[]. The current check only rejects values
strictly larger than the record count, so an index equal to count still
falls through and reaches the fixed table one element past the end.

Reject indices at or above the number of available records before using
them as an array index.

Signed-off-by: default avatarPengpeng Hou <pengpeng@iscas.ac.cn>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 31b8de5e

drivers/gpu/drm/amd/display/dc/bios/bios_parser.c

+1 −1
Original line number Diff line number Diff line
@@ -1963,7 +1963,7 @@ static enum bp_result get_gpio_i2c_info(struct bios_parser *bp, 
	count = (le16_to_cpu(header->sHeader.usStructureSize)

			- sizeof(ATOM_COMMON_TABLE_HEADER))

				/ sizeof(ATOM_GPIO_I2C_ASSIGMENT);

	if (count < record->sucI2cId.bfI2C_LineMux)

	if (count <= record->sucI2cId.bfI2C_LineMux)

		return BP_RESULT_BADBIOSTABLE;



	/* get the GPIO_I2C_INFO */