Commit 12ff2a4a authored by Mohsin Bashir's avatar Mohsin Bashir Committed by Jakub Kicinski
Browse files

eth: fbnic: Use wake instead of start 



fbnic_up() calls netif_tx_start_all_queues(), which only clears
__QUEUE_STATE_DRV_XOFF.  If qdisc backlog has accumulated on any TX
queue before the reconfiguration (e.g. ring resize via ethtool -G),
start does not call __netif_schedule() to kick the qdisc, so the
pending backlog is never drained and the queue stalls.

Switch to netif_tx_wake_all_queues(), which clears DRV_XOFF and also
calls __netif_schedule() on every queue, ensuring any backlog that
built up before the down/up cycle is promptly dequeued.

Fixes: bc610777 ("eth: fbnic: Allocate a netdevice and napi vectors with queues")
Signed-off-by: default avatarMohsin Bashir <hmohsin@meta.com>
Link: https://patch.msgid.link/20260408002415.2963915-1-mohsin.bashr@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4ae0604a

drivers/net/ethernet/meta/fbnic/fbnic_pci.c

+1 −1
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ void fbnic_up(struct fbnic_net *fbn) 


	/* Enable Tx/Rx processing */

	fbnic_napi_enable(fbn);

	netif_tx_start_all_queues(fbn->netdev);

	netif_tx_wake_all_queues(fbn->netdev);



	fbnic_service_task_start(fbn);