Unverified Commit 130eb72d authored by Tang Bin's avatar Tang Bin Committed by Mark Brown
Browse files

ASoC: codecs: fix the right check and simplify code 



In the file drivers/base/platform.c, the return description of
platform_get_irq is 'non-zero IRQ number on success, negative
error number on failure.', so the check is wrong, fix it. And
when get irq failed, the function platform_get_irq logs an error
message.

Fixes: 5e240449 ("ASoC: codecs: add MT6357 support")
Signed-off-by: default avatarTang Bin <tangbin@cmss.chinamobile.com>
Link: https://patch.msgid.link/20240908134604.3652-1-tangbin@cmss.chinamobile.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 876dec03

sound/soc/mediatek/mt8365/mt8365-afe-pcm.c

+5 −5
Original line number Diff line number Diff line
@@ -2155,11 +2155,11 @@ static int mt8365_afe_pcm_dev_probe(struct platform_device *pdev) 
	for (i = 0; i < afe->irqs_size; i++)

		afe->irqs[i].irq_data = &irq_data[i];



	irq_id = platform_get_irq(pdev, 0);

	if (!irq_id) {

		dev_err_probe(afe->dev, irq_id, "np %s no irq\n", afe->dev->of_node->name);

		return -ENXIO;

	}

	ret = platform_get_irq(pdev, 0);

	if (ret < 0)

		return ret;



	irq_id = ret;

	ret = devm_request_irq(afe->dev, irq_id, mt8365_afe_irq_handler,

			       0, "Afe_ISR_Handle", (void *)afe);

	if (ret)