Unverified Commit 130f3356 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Krzysztof Wilczyński
Browse files

misc: pci_endpoint_test: Remove usage of the deprecated ida_simple_*() API 

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove() functions.

This is also less verbose.

Link: https://lore.kernel.org/linux-pci/47a30441242c4d5f0e00555cbddd7783350ff1b2.1702966523.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 0eccea71

drivers/misc/pci_endpoint_test.c

+3 −3
Original line number Diff line number Diff line
@@ -860,7 +860,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, 


	pci_set_drvdata(pdev, test);



	id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL);

	id = ida_alloc(&pci_endpoint_test_ida, GFP_KERNEL);

	if (id < 0) {

		err = id;

		dev_err(dev, "Unable to get id\n");
@@ -907,7 +907,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev, 
	kfree(test->name);



err_ida_remove:

	ida_simple_remove(&pci_endpoint_test_ida, id);

	ida_free(&pci_endpoint_test_ida, id);



err_iounmap:

	for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
@@ -943,7 +943,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) 
	misc_deregister(&test->miscdev);

	kfree(misc_device->name);

	kfree(test->name);

	ida_simple_remove(&pci_endpoint_test_ida, id);

	ida_free(&pci_endpoint_test_ida, id);

	for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {

		if (test->bar[bar])

			pci_iounmap(pdev, test->bar[bar]);