Commit 134d3cfb authored by Julia Lawall's avatar Julia Lawall Committed by Ulf Hansson
Browse files

mmc: atmel-mci: add missing of_node_put 



for_each_child_of_node performs an of_node_get on each
iteration, so a break out of the loop requires an
of_node_put.

This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Link: https://lore.kernel.org/r/20230907095521.14053-6-Julia.Lawall@inria.fr


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent bbe6dc42

drivers/mmc/host/atmel-mci.c

+6 −2
Original line number Diff line number Diff line
@@ -674,8 +674,10 @@ atmci_of_init(struct platform_device *pdev) 
					      "cd", GPIOD_IN, "cd-gpios");

		err = PTR_ERR_OR_ZERO(pdata->slot[slot_id].detect_pin);

		if (err) {

			if (err != -ENOENT)

			if (err != -ENOENT) {

				of_node_put(cnp);

				return ERR_PTR(err);

			}

			pdata->slot[slot_id].detect_pin = NULL;

		}
@@ -687,8 +689,10 @@ atmci_of_init(struct platform_device *pdev) 
					      "wp", GPIOD_IN, "wp-gpios");

		err = PTR_ERR_OR_ZERO(pdata->slot[slot_id].wp_pin);

		if (err) {

			if (err != -ENOENT)

			if (err != -ENOENT) {

				of_node_put(cnp);

				return ERR_PTR(err);

			}

			pdata->slot[slot_id].wp_pin = NULL;

		}

	}