Commit 136c5b40 authored by Zi Yan's avatar Zi Yan Committed by Andrew Morton
Browse files

selftests/mm: use selftests framework to print test result 

Otherwise the number of tests does not match the reality.

Link: https://lkml.kernel.org/r/20250110235028.96824-1-ziy@nvidia.com


Fixes: 391e8697 ("mm: selftest to verify zero-filled pages are mapped to zeropage")
Signed-off-by: default avatarZi Yan <ziy@nvidia.com>
Cc: Alexander Zhu <alexlzhu@fb.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Usama Arif <usamaarif642@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 91fe0e4d

tools/testing/selftests/mm/split_huge_page_test.c

+12 −22
Original line number Diff line number Diff line
@@ -108,38 +108,28 @@ static void verify_rss_anon_split_huge_page_all_zeroes(char *one_page, int nr_hp 
	unsigned long rss_anon_before, rss_anon_after;

	size_t i;



	if (!check_huge_anon(one_page, 4, pmd_pagesize)) {

		printf("No THP is allocated\n");

		exit(EXIT_FAILURE);

	}

	if (!check_huge_anon(one_page, 4, pmd_pagesize))

		ksft_exit_fail_msg("No THP is allocated\n");



	rss_anon_before = rss_anon();

	if (!rss_anon_before) {

		printf("No RssAnon is allocated before split\n");

		exit(EXIT_FAILURE);

	}

	if (!rss_anon_before)

		ksft_exit_fail_msg("No RssAnon is allocated before split\n");



	/* split all THPs */

	write_debugfs(PID_FMT, getpid(), (uint64_t)one_page,

		      (uint64_t)one_page + len, 0);



	for (i = 0; i < len; i++)

		if (one_page[i] != (char)0) {

			printf("%ld byte corrupted\n", i);

			exit(EXIT_FAILURE);

		}

		if (one_page[i] != (char)0)

			ksft_exit_fail_msg("%ld byte corrupted\n", i);



	if (!check_huge_anon(one_page, 0, pmd_pagesize)) {

		printf("Still AnonHugePages not split\n");

		exit(EXIT_FAILURE);

	}

	if (!check_huge_anon(one_page, 0, pmd_pagesize))

		ksft_exit_fail_msg("Still AnonHugePages not split\n");



	rss_anon_after = rss_anon();

	if (rss_anon_after >= rss_anon_before) {

		printf("Incorrect RssAnon value. Before: %ld After: %ld\n",

	if (rss_anon_after >= rss_anon_before)

		ksft_exit_fail_msg("Incorrect RssAnon value. Before: %ld After: %ld\n",

		       rss_anon_before, rss_anon_after);

		exit(EXIT_FAILURE);

	}

}



void split_pmd_zero_pages(void)
@@ -150,7 +140,7 @@ void split_pmd_zero_pages(void) 


	one_page = allocate_zero_filled_hugepage(len);

	verify_rss_anon_split_huge_page_all_zeroes(one_page, nr_hpages, len);

	printf("Split zero filled huge pages successful\n");

	ksft_test_result_pass("Split zero filled huge pages successful\n");

	free(one_page);

}
@@ -491,7 +481,7 @@ int main(int argc, char **argv) 
	if (argc > 1)

		optional_xfs_path = argv[1];



	ksft_set_plan(3+9);

	ksft_set_plan(4+9);



	pagesize = getpagesize();

	pageshift = ffs(pagesize) - 1;