Commit 1373ca10 authored Oct 31, 2023 by Yuezhang Mo Committed by Namjae Jeon Nov 03, 2023

exfat: fix ctime is not updated



Commit 4c72a36e ("exfat: convert to new timestamp accessors")
removed attr_copy() from exfat_set_attr().
It causes xfstests generic/221 to fail. In xfstests generic/221,
it tests ctime should be updated even if futimens() update atime
only. But in this case, ctime will not be updated if attr_copy()
is removed.

attr_copy() may also update other attributes, and removing it may
cause other bugs, so this commit restores to call attr_copy() in
exfat_set_attr().

Fixes: 4c72a36e ("exfat: convert to new timestamp accessors")
Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Reviewed-by: Andy Wu <Andy.Wu@sony.com>
Reviewed-by: Aoyama Wataru <wataru.aoyama@sony.com>
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>

parent fc12a722

fs/exfat/file.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -295,6 +295,7 @@ int exfat_setattr(struct mnt_idmap idmap, struct dentry dentry,
		if (attr->ia_valid & ATTR_SIZE)
		inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));

		setattr_copy(&nop_mnt_idmap, inode, attr);
		exfat_truncate_inode_atime(inode);

		if (attr->ia_valid & ATTR_SIZE) {