Commit 1390b8b3 authored by Przemek Kitszel's avatar Przemek Kitszel Committed by Tony Nguyen
Browse files

ice: remove duplicate call to ice_deinit_hw() on error paths 



Current unwinding code on error paths of ice_devlink_reinit_up() and
ice_probe() have manual call to ice_deinit_hw() (which is good, as there
is also manual call to ice_hw_init() there), which is then duplicated
(and was prior current series) in ice_deinit_dev().

Fix the above by removing ice_deinit_hw() from ice_deinit_dev().
Add a (now missing) call in ice_remove().

Reported-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/intel-wired-lan/20250717-jk-ddp-safe-mode-issue-v1-1-e113b2baed79@intel.com/


Fixes: 4d3f59bf ("ice: split ice_init_hw() out from ice_init_dev()")
Signed-off-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 8a37f9e2

drivers/net/ethernet/intel/ice/ice_main.c

+1 −1
Original line number Diff line number Diff line
@@ -4784,7 +4784,6 @@ int ice_init_dev(struct ice_pf *pf) 


void ice_deinit_dev(struct ice_pf *pf)

{

	ice_deinit_hw(&pf->hw);

	ice_service_task_stop(pf);



	/* Service task is already stopped, so call reset directly. */
@@ -5466,6 +5465,7 @@ static void ice_remove(struct pci_dev *pdev) 
	ice_set_wake(pf);



	ice_adapter_put(pdev);

	ice_deinit_hw(&pf->hw);



	ice_deinit_dev(pf);

	ice_aq_cancel_waiting_tasks(pf);