Commit 13989207 authored by Justin Tee's avatar Justin Tee Committed by Keith Busch
Browse files

nvme-fabrics: add ENOKEY to no retry criteria for authentication failures 

With authentication, in addition to EKEYREJECTED there is also no point in
retrying reconnects when status is ENOKEY.  Thus, add -ENOKEY as another
criteria to determine when to stop retries.

Cc: Daniel Wagner <wagi@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>
Closes: https://lore.kernel.org/linux-nvme/20250829-nvme-fc-sync-v3-0-d69c87e63aee@kernel.org/


Signed-off-by: default avatarJustin Tee <justintee8345@gmail.com>
Tested-by: default avatarDaniel Wagner <wagi@kernel.org>
Reviewed-by: default avatarDaniel Wagner <wagi@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent bb9f4cca

drivers/nvme/host/fabrics.c

+1 −1
Original line number Diff line number Diff line
@@ -592,7 +592,7 @@ bool nvmf_should_reconnect(struct nvme_ctrl *ctrl, int status) 
	if (status > 0 && (status & NVME_STATUS_DNR))

		return false;



	if (status == -EKEYREJECTED)

	if (status == -EKEYREJECTED || status == -ENOKEY)

		return false;



	if (ctrl->opts->max_reconnects == -1 ||