Commit 13bcd440 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Greg Kroah-Hartman
Browse files

nvmem: core: verify cell's raw_len 



Check that the NVMEM cell's raw_len is a aligned to word_size. Otherwise
Otherwise drivers might face incomplete read while accessing the last
part of the NVMEM cell.

Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20250411112251.68002-10-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7a06ef75

drivers/nvmem/core.c

+12 −0
Original line number Diff line number Diff line
@@ -605,6 +605,18 @@ static int nvmem_cell_info_to_nvmem_cell_entry_nodup(struct nvmem_device *nvmem, 
		return -EINVAL;

	}



	if (!IS_ALIGNED(cell->raw_len, nvmem->word_size)) {

		dev_err(&nvmem->dev,

			"cell %s raw len %zd unaligned to nvmem word size %d\n",

			cell->name ?: "<unknown>", cell->raw_len,

			nvmem->word_size);



		if (info->raw_len)

			return -EINVAL;



		cell->raw_len = ALIGN(cell->raw_len, nvmem->word_size);

	}



	return 0;

}