Commit 13c8fb98 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: atmel_lcdfb: Stop using platform_driver_probe() 



On today's platforms the benefit of platform_driver_probe() isn't that
relevant any more. It allows to drop some code after booting (or module
loading) for .probe() and discard the .remove() function completely if
the driver is built-in. This typically saves a few 100k.

The downside of platform_driver_probe() is that the driver cannot be
bound and unbound at runtime which is ancient and also slightly
complicates testing. There are also thoughts to deprecate
platform_driver_probe() because it adds some complexity in the driver
core for little gain. Also many drivers don't use it correctly. This
driver for example misses to mark the driver struct with __refdata which
is needed to suppress a (W=1) modpost warning:

	WARNING: modpost: drivers/video/fbdev/atmel_lcdfb: section mismatch in reference: atmel_lcdfb_driver+0x4 (section: .data) -> atmel_lcdfb_remove (section: .exit.text)

[folded in patch by Nathan Chancellor]

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent aba6ab57

drivers/video/fbdev/atmel_lcdfb.c

+7 −7
Original line number Diff line number Diff line
@@ -220,7 +220,7 @@ static inline void atmel_lcdfb_power_control(struct atmel_lcdfb_info *sinfo, int 
	}

}



static const struct fb_fix_screeninfo atmel_lcdfb_fix __initconst = {

static const struct fb_fix_screeninfo atmel_lcdfb_fix = {

	.type		= FB_TYPE_PACKED_PIXELS,

	.visual		= FB_VISUAL_TRUECOLOR,

	.xpanstep	= 0,
@@ -841,7 +841,7 @@ static void atmel_lcdfb_task(struct work_struct *work) 
	atmel_lcdfb_reset(sinfo);

}



static int __init atmel_lcdfb_init_fbinfo(struct atmel_lcdfb_info *sinfo)

static int atmel_lcdfb_init_fbinfo(struct atmel_lcdfb_info *sinfo)

{

	struct fb_info *info = sinfo->info;

	int ret = 0;
@@ -1017,7 +1017,7 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo) 
	return ret;

}



static int __init atmel_lcdfb_probe(struct platform_device *pdev)

static int atmel_lcdfb_probe(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct fb_info *info;
@@ -1223,7 +1223,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) 
	return ret;

}



static int __exit atmel_lcdfb_remove(struct platform_device *pdev)

static int atmel_lcdfb_remove(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct fb_info *info = dev_get_drvdata(dev);
@@ -1301,7 +1301,8 @@ static int atmel_lcdfb_resume(struct platform_device *pdev) 
#endif



static struct platform_driver atmel_lcdfb_driver = {

	.remove		= __exit_p(atmel_lcdfb_remove),

	.probe		= atmel_lcdfb_probe,

	.remove		= atmel_lcdfb_remove,

	.suspend	= atmel_lcdfb_suspend,

	.resume		= atmel_lcdfb_resume,

	.driver		= {
@@ -1309,8 +1310,7 @@ static struct platform_driver atmel_lcdfb_driver = { 
		.of_match_table	= atmel_lcdfb_dt_ids,

	},

};



module_platform_driver_probe(atmel_lcdfb_driver, atmel_lcdfb_probe);

module_platform_driver(atmel_lcdfb_driver);



MODULE_DESCRIPTION("AT91 LCD Controller framebuffer driver");

MODULE_AUTHOR("Nicolas Ferre <nicolas.ferre@atmel.com>");