Unverified Commit 13d30682 authored by Cássio Gabriel's avatar Cássio Gabriel Committed by Mark Brown
Browse files

ASoC: Intel: bytcr_wm5102: Fix MCLK leak on platform_clock_control error 



If byt_wm5102_prepare_and_enable_pll1() fails in the
SND_SOC_DAPM_EVENT_ON() path, platform_clock_control() returns after
clk_prepare_enable(priv->mclk) without disabling the clock again.

This leaks an MCLK enable reference on failed power-up attempts. Add the
missing clk_disable_unprepare() on the error path, matching the unwind
used by the other Intel platform_clock_control() implementations.

Fixes: 9a87fc1e ("ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarCássio Gabriel <cassiogabrielcontato@gmail.com>
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: default avatarHans de Goede <johannes.goede@oss.qualcomm.com>
Link: https://patch.msgid.link/20260427-bytcr-wm5102-mclk-leak-v1-1-02b96d08e99c@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 241ee17e

sound/soc/intel/boards/bytcr_wm5102.c

+1 −0
Original line number Diff line number Diff line
@@ -170,6 +170,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w, 
		ret = byt_wm5102_prepare_and_enable_pll1(codec_dai, 48000);

		if (ret) {

			dev_err(card->dev, "Error setting codec sysclk: %d\n", ret);

			clk_disable_unprepare(priv->mclk);

			return ret;

		}

	} else {