Commit 141ecc53 authored by Cornelia Huck's avatar Cornelia Huck Committed by Greg Kroah-Hartman
Browse files

driver core fixes: device_create_file() retval check in dmapool.c 



Check for device_create_file() return value in dma_pool_create().

Signed-off-by: default avatarCornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a306eea4

drivers/base/dmapool.c

+11 −2
Original line number Diff line number Diff line
@@ -141,11 +141,20 @@ dma_pool_create (const char *name, struct device *dev, 
	init_waitqueue_head (&retval->waitq);



	if (dev) {

		int ret;



		down (&pools_lock);

		if (list_empty (&dev->dma_pools))

			device_create_file (dev, &dev_attr_pools);

			ret = device_create_file (dev, &dev_attr_pools);

		else

			ret = 0;

		/* note:  not currently insisting "name" be unique */

		if (!ret)

			list_add (&retval->pools, &dev->dma_pools);

		else {

			kfree(retval);

			retval = NULL;

		}

		up (&pools_lock);

	} else

		INIT_LIST_HEAD (&retval->pools);