Commit 1435e895 authored by Wentao Liang's avatar Wentao Liang Committed by Alex Deucher
Browse files

drm/amdgpu: handle amdgpu_cgs_create_device() errors in amd_powerplay_create() 



Add error handling to propagate amdgpu_cgs_create_device() failures
to the caller. When amdgpu_cgs_create_device() fails, release hwmgr
and return -ENOMEM to prevent null pointer dereference.

[v1]->[v2]: Change error code from -EINVAL to -ENOMEM. Free hwmgr.

Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent bd4b125e

drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c

+5 −0
Original line number Diff line number Diff line
@@ -51,6 +51,11 @@ static int amd_powerplay_create(struct amdgpu_device *adev) 
	hwmgr->adev = adev;

	hwmgr->not_vf = !amdgpu_sriov_vf(adev);

	hwmgr->device = amdgpu_cgs_create_device(adev);

	if (!hwmgr->device) {

		kfree(hwmgr);

		return -ENOMEM;

	}



	mutex_init(&hwmgr->msg_lock);

	hwmgr->chip_family = adev->family;

	hwmgr->chip_id = adev->asic_type;