Commit 143667ee authored by Max Gurtovoy's avatar Max Gurtovoy Committed by Keith Busch
Browse files

nvmet: compare mqes and sqsize only for IO SQ 



According to the NVMe Spec:
"
MQES: This field indicates the maximum individual queue size that the
controller supports. For NVMe over PCIe implementations, this value
applies to the I/O Submission Queues and I/O Completion Queues that the
host creates. For NVMe over Fabrics implementations, this value applies
to only the I/O Submission Queues that the host creates.
"

Align the target code to compare mqes and sqsize as mentioned in the
NVMe Spec.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarMax Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 25802f3a

drivers/nvme/target/fabrics-cmd.c

+2 −1
Original line number Diff line number Diff line
@@ -157,7 +157,8 @@ static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req) 
		return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;

	}



	if (sqsize > mqes) {

	/* for fabrics, this value applies to only the I/O Submission Queues */

	if (qid && sqsize > mqes) {

		pr_warn("sqsize %u is larger than MQES supported %u cntlid %d\n",

				sqsize, mqes, ctrl->cntlid);

		req->error_loc = offsetof(struct nvmf_connect_command, sqsize);