Unverified Commit 144acef3 authored Dec 13, 2024 by Christian Brauner

fs: add mount namespace to rbtree late

There's no point doing that under the namespace semaphore it just gives
the false impression that it protects the mount namespace rbtree and it
simply doesn't.

Link: https://lore.kernel.org/r/20241213-work-mount-rbtree-lockless-v3-2-6e3cdaf9b280@kernel.org


Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>

parent 62b8dee9

fs/namespace.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3981,7 +3981,6 @@ struct mnt_namespace copy_mnt_ns(unsigned long flags, struct mnt_namespace ns,
		while (p->mnt.mnt_root != q->mnt.mnt_root)
		p = next_mnt(skip_mnt_tree(p), old);
		}
		mnt_ns_tree_add(new_ns);
		namespace_unlock();

		if (rootmnt)
		@@ -3989,6 +3988,7 @@ struct mnt_namespace copy_mnt_ns(unsigned long flags, struct mnt_namespace ns,
		if (pwdmnt)
		mntput(pwdmnt);

		mnt_ns_tree_add(new_ns);
		return new_ns;
		}