Commit 149fc357 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Helgaas
Browse files

PCI: layerscape: Use syscon_regmap_lookup_by_phandle_args 

Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
syscon_regmap_lookup_by_phandle() combined with getting the syscon
argument.  Except simpler code this annotates within one line that given
phandle has arguments, so grepping for code would be easier.

Link: https://lore.kernel.org/r/20250112-syscon-phandle-args-pci-v1-2-fcb6ebcc0afc@linaro.org


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Acked-by: default avatarRoy Zang <Roy.Zang@nxp.com>
parent 40384c84

drivers/pci/controller/dwc/pci-layerscape.c

+4 −6
Original line number Diff line number Diff line
@@ -329,7 +329,6 @@ static int ls_pcie_probe(struct platform_device *pdev) 
	struct ls_pcie *pcie;

	struct resource *dbi_base;

	u32 index[2];

	int ret;



	pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);

	if (!pcie)
@@ -355,16 +354,15 @@ static int ls_pcie_probe(struct platform_device *pdev) 
	pcie->pf_lut_base = pci->dbi_base + pcie->drvdata->pf_lut_off;



	if (pcie->drvdata->scfg_support) {

		pcie->scfg = syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,pcie-scfg");

		pcie->scfg =

			syscon_regmap_lookup_by_phandle_args(dev->of_node,

							     "fsl,pcie-scfg", 2,

							     index);

		if (IS_ERR(pcie->scfg)) {

			dev_err(dev, "No syscfg phandle specified\n");

			return PTR_ERR(pcie->scfg);

		}



		ret = of_property_read_u32_array(dev->of_node, "fsl,pcie-scfg", index, 2);

		if (ret)

			return ret;



		pcie->index = index[1];

	}