Commit 14f08c97 authored by limingming3's avatar limingming3 Committed by Daniel Bristot de Oliveira
Browse files

tools/rtla: Replace setting prio with nice for SCHED_OTHER 

Since the sched_priority for SCHED_OTHER is always 0, it makes no
sence to set it.
Setting nice for SCHED_OTHER seems more meaningful.

Link: https://lkml.kernel.org/r/20240207065142.1753909-1-limingming3@lixiang.com



Cc: stable@vger.kernel.org
Fixes: b1696371 ("rtla: Helper functions for rtla")
Signed-off-by: default avatarlimingming3 <limingming3@lixiang.com>
Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@kernel.org>
parent 61ec586b

tools/tracing/rtla/src/utils.c

+3 −3
Original line number Diff line number Diff line
@@ -473,13 +473,13 @@ int parse_prio(char *arg, struct sched_attr *sched_param) 
		if (prio == INVALID_VAL)

			return -1;



		if (prio < sched_get_priority_min(SCHED_OTHER))

		if (prio < MIN_NICE)

			return -1;

		if (prio > sched_get_priority_max(SCHED_OTHER))

		if (prio > MAX_NICE)

			return -1;



		sched_param->sched_policy   = SCHED_OTHER;

		sched_param->sched_priority = prio;

		sched_param->sched_nice = prio;

		break;

	default:

		return -1;

tools/tracing/rtla/src/utils.h

+2 −0
Original line number Diff line number Diff line
@@ -9,6 +9,8 @@ 
 */

#define BUFF_U64_STR_SIZE	24

#define MAX_PATH		1024

#define MAX_NICE		20

#define MIN_NICE		-19



#define container_of(ptr, type, member)({			\

	const typeof(((type *)0)->member) *__mptr = (ptr);	\