Commit 1531a2bb authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: gadget: s3c2410_udc: remove dentry storage for debugfs file 

There is no need to store the dentry pointer for a debugfs file that we
only use to remove it when the device goes away.  debugfs can do the
lookup for us instead, saving us some trouble, and making things smaller
overall.

Cc: Felipe Balbi <balbi@kernel.org>
Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20210518162105.3698090-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e3d59eff

drivers/usb/gadget/udc/s3c2410_udc.c

+3 −4
Original line number Diff line number Diff line
@@ -1843,8 +1843,7 @@ static int s3c2410_udc_probe(struct platform_device *pdev) 
	if (retval)

		goto err_add_udc;



	udc->regs_info = debugfs_create_file("registers", S_IRUGO,

					     s3c2410_udc_debugfs_root, udc,

	debugfs_create_file("registers", S_IRUGO, s3c2410_udc_debugfs_root, udc,

			    &s3c2410_udc_debugfs_fops);



	dev_dbg(dev, "probe ok\n");
@@ -1889,7 +1888,7 @@ static int s3c2410_udc_remove(struct platform_device *pdev) 
		return -EBUSY;



	usb_del_gadget_udc(&udc->gadget);

	debugfs_remove(udc->regs_info);

	debugfs_remove(debugfs_lookup("registers", s3c2410_udc_debugfs_root));



	if (udc_info && !udc_info->udc_command &&

		gpio_is_valid(udc_info->pullup_pin))

drivers/usb/gadget/udc/s3c2410_udc.h

+0 −1
Original line number Diff line number Diff line
@@ -89,7 +89,6 @@ struct s3c2410_udc { 
	unsigned			req_config : 1;

	unsigned			req_pending : 1;

	u8				vbus;

	struct dentry			*regs_info;

	int				irq;

};

#define to_s3c2410(g)	(container_of((g), struct s3c2410_udc, gadget))