Commit 1532c5d6 authored by Daniel Gabay's avatar Daniel Gabay Committed by Johannes Berg
Browse files

wifi: iwlwifi: mvm: Use IWL_FW_CHECK() for BAR notif size validation 



Use IWL_FW_CHECK() for BAR notification size validation, improving
diagnostics with a clear error message on failure.

Signed-off-by: default avatarDaniel Gabay <daniel.gabay@intel.com>
Reviewed-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241226174257.913d5d476929.I8cd62f45bacc088c309b0152fc392dc2579e82e0@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9b45ba39

drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

+4 −1
Original line number Diff line number Diff line
@@ -2507,9 +2507,12 @@ void iwl_mvm_rx_bar_frame_release(struct iwl_mvm *mvm, struct napi_struct *napi, 
	struct iwl_rx_packet *pkt = rxb_addr(rxb);

	struct iwl_bar_frame_release *release = (void *)pkt->data;

	struct iwl_mvm_baid_data *baid_data;

	u32 pkt_len = iwl_rx_packet_payload_len(pkt);

	unsigned int baid, nssn, sta_id, tid;



	if (unlikely(iwl_rx_packet_payload_len(pkt) < sizeof(*release)))

	if (IWL_FW_CHECK(mvm, pkt_len < sizeof(*release),

			 "Unexpected frame release notif size %d (expected %zu)\n",

			 pkt_len, sizeof(*release)))

		return;



	baid = le32_get_bits(release->ba_info,