Commit 1561d96f authored by Samasth Norway Ananda's avatar Samasth Norway Ananda Committed by Bartosz Golaszewski
Browse files

gpio: tegra: fix irq_release_resources calling enable instead of disable 



tegra_gpio_irq_release_resources() erroneously calls tegra_gpio_enable()
instead of tegra_gpio_disable(). When IRQ resources are released, the
GPIO configuration bit (CNF) should be cleared to deconfigure the pin as
a GPIO. Leaving it enabled wastes power and can cause unexpected behavior
if the pin is later reused for an alternate function via pinctrl.

Fixes: 66fecef5 ("gpio: tegra: Convert to gpio_irq_chip")
Signed-off-by: default avatarSamasth Norway Ananda <samasth.norway.ananda@oracle.com>
Link: https://patch.msgid.link/20260407210247.1737938-1-samasth.norway.ananda@oracle.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
parent 828ec7f8

drivers/gpio/gpio-tegra.c

+1 −1
Original line number Diff line number Diff line
@@ -595,7 +595,7 @@ static void tegra_gpio_irq_release_resources(struct irq_data *d) 
	struct tegra_gpio_info *tgi = gpiochip_get_data(chip);



	gpiochip_relres_irq(chip, d->hwirq);

	tegra_gpio_enable(tgi, d->hwirq);

	tegra_gpio_disable(tgi, d->hwirq);

}



static void tegra_gpio_irq_print_chip(struct irq_data *d, struct seq_file *s)