Commit 156c0ab1 authored by Lijo Lazar's avatar Lijo Lazar Committed by Alex Deucher
Browse files

drm/amd/pm: Remove unused logic in SMUv14.0.2 



Remove commented and redundant logic in get_allowed_feature_mask
implementation.

Signed-off-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Reviewed-by: default avatarAsad Kamal <asad.kamal@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c99d381d

drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c

+0 −39
Original line number Diff line number Diff line
@@ -268,50 +268,11 @@ static int 
smu_v14_0_2_get_allowed_feature_mask(struct smu_context *smu,

				  uint32_t *feature_mask, uint32_t num)

{

	struct amdgpu_device *adev = smu->adev;

	/*u32 smu_version;*/



	if (num > 2)

		return -EINVAL;



	memset(feature_mask, 0xff, sizeof(uint32_t) * num);



	if (adev->pm.pp_feature & PP_SCLK_DPM_MASK) {

		*(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT);

		*(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFX_IMU_BIT);

	}

#if 0

	if (!(adev->pg_flags & AMD_PG_SUPPORT_ATHUB) ||

	    !(adev->pg_flags & AMD_PG_SUPPORT_MMHUB))

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_ATHUB_MMHUB_PG_BIT);



	if (!(adev->pm.pp_feature & PP_SOCCLK_DPM_MASK))

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT);



	/* PMFW 78.58 contains a critical fix for gfxoff feature */

	smu_cmn_get_smc_version(smu, NULL, &smu_version);

	if ((smu_version < 0x004e3a00) ||

	     !(adev->pm.pp_feature & PP_GFXOFF_MASK))

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_GFXOFF_BIT);



	if (!(adev->pm.pp_feature & PP_MCLK_DPM_MASK)) {

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_DPM_UCLK_BIT);

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_VMEMP_SCALING_BIT);

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_VDDIO_MEM_SCALING_BIT);

	}



	if (!(adev->pm.pp_feature & PP_SCLK_DEEP_SLEEP_MASK))

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_DS_GFXCLK_BIT);



	if (!(adev->pm.pp_feature & PP_PCIE_DPM_MASK)) {

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_DPM_LINK_BIT);

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_DS_LCLK_BIT);

	}



	if (!(adev->pm.pp_feature & PP_ULV_MASK))

		*(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_GFX_ULV_BIT);

#endif



	return 0;

}