Commit 157519c0 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Ulf Hansson
Browse files

cpuidle: dt_idle_genpd: Simplify with scoped for each OF child loop 



Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240816150931.142208-4-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 7aa1204d

drivers/cpuidle/dt_idle_genpd.c

+4 −10
Original line number Diff line number Diff line
@@ -130,11 +130,10 @@ struct generic_pm_domain *dt_idle_pd_alloc(struct device_node *np, 


int dt_idle_pd_init_topology(struct device_node *np)

{

	struct device_node *node;

	struct of_phandle_args child, parent;

	int ret;



	for_each_child_of_node(np, node) {

	for_each_child_of_node_scoped(np, node) {

		if (of_parse_phandle_with_args(node, "power-domains",

					"#power-domain-cells", 0, &parent))

			continue;
@@ -143,22 +142,19 @@ int dt_idle_pd_init_topology(struct device_node *np) 
		child.args_count = 0;

		ret = of_genpd_add_subdomain(&parent, &child);

		of_node_put(parent.np);

		if (ret) {

			of_node_put(node);

		if (ret)

			return ret;

	}

	}



	return 0;

}



int dt_idle_pd_remove_topology(struct device_node *np)

{

	struct device_node *node;

	struct of_phandle_args child, parent;

	int ret;



	for_each_child_of_node(np, node) {

	for_each_child_of_node_scoped(np, node) {

		if (of_parse_phandle_with_args(node, "power-domains",

					"#power-domain-cells", 0, &parent))

			continue;
@@ -167,11 +163,9 @@ int dt_idle_pd_remove_topology(struct device_node *np) 
		child.args_count = 0;

		ret = of_genpd_remove_subdomain(&parent, &child);

		of_node_put(parent.np);

		if (ret) {

			of_node_put(node);

		if (ret)

			return ret;

	}

	}



	return 0;

}