Commit 159f2efa authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

RDMA/mana: Remove user triggerable WARN_ON() in mana_ib_create_qp_rss() 

Sashiko points out that the user can specify WQs sharing the same CQ as a
part of the uAPI and this will trigger the WARN_ON() then go on to corrupt
the kernel.

Just reject it outright and fail the QP creation.

Cc: stable@vger.kernel.org
Fixes: c15d7802 ("RDMA/mana_ib: Add CQ interrupt support for RAW QP")
Link: https://sashiko.dev/#/patchset/0-v2-1c49eeb88c48%2B91-rdma_udata_rep_jgg%40nvidia.com?part=1
Link: https://patch.msgid.link/r/5-v1-41f3135e5565+9d2-rdma_ai_fixes1_jgg@nvidia.com


Reviewed-by: default avatarLong Li <longli@microsoft.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 6dd2d4ad

drivers/infiniband/hw/mana/cq.c

+3 −2
Original line number Diff line number Diff line
@@ -137,8 +137,9 @@ int mana_ib_install_cq_cb(struct mana_ib_dev *mdev, struct mana_ib_cq *cq) 


	if (cq->queue.id >= gc->max_num_cqs)

		return -EINVAL;

	/* Create CQ table entry */

	WARN_ON(gc->cq_table[cq->queue.id]);

	/* Create CQ table entry, sharing a CQ between WQs is not supported */

	if (gc->cq_table[cq->queue.id])

		return -EINVAL;

	if (cq->queue.kmem)

		gdma_cq = cq->queue.kmem;

	else