Commit 15aca30c authored by Murad Masimov's avatar Murad Masimov Committed by Sebastian Reichel
Browse files

power: supply: rt9467: Prevent using uninitialized local variable in rt9467_set_value_from_ranges() 



There is a typo in rt9467_set_value_from_ranges() that can cause leaving local
variable sel with an undefined value which is then used in regmap_field_write().

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 6f7f70e3 ("power: supply: rt9467: Add Richtek RT9467 charger driver")
Signed-off-by: default avatarMurad Masimov <m.masimov@mt-integration.ru>
Link: https://patch.msgid.link/20251009145308.1830893-1-m.masimov@mt-integration.ru


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 8b27fe2d

drivers/power/supply/rt9467-charger.c

+1 −1
Original line number Diff line number Diff line
@@ -376,7 +376,7 @@ static int rt9467_set_value_from_ranges(struct rt9467_chg_data *data, 
	if (rsel == RT9467_RANGE_VMIVR) {

		ret = linear_range_get_selector_high(range, value, &sel, &found);

		if (ret)

			value = range->max_sel;

			sel = range->max_sel;

	} else {

		linear_range_get_selector_within(range, value, &sel);

	}