Commit 15c7e87a authored by Oswald Buddenhagen's avatar Oswald Buddenhagen Committed by Takashi Iwai
Browse files

ALSA: emu10k1: make E-MU FPGA writes potentially more reliable 



We did not delay after the second strobe signal, so another immediately
following access could potentially corrupt the written value.

This is a purely speculative fix with no supporting evidence, but after
taking out the spinlocks around the writes, it seems plausible that a
modern processor could be actually too fast. Also, it's just cleaner to
be consistent.

Signed-off-by: default avatarOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Message-ID: <20240428093716.3198666-7-oswald.buddenhagen@gmx.de>
parent e8289fd3

sound/pci/emu10k1/io.c

+1 −0
Original line number Diff line number Diff line
@@ -285,6 +285,7 @@ static void snd_emu1010_fpga_write_locked(struct snd_emu10k1 *emu, u32 reg, u32 
	outw(value, emu->port + A_GPIO);

	udelay(10);

	outw(value | 0x80 , emu->port + A_GPIO);  /* High bit clocks the value into the fpga. */

	udelay(10);

}



void snd_emu1010_fpga_write(struct snd_emu10k1 *emu, u32 reg, u32 value)