Commit 15df2869 authored by Finn Thain's avatar Finn Thain Committed by Helge Deller
Browse files

fbdev: Fix logic error in "offb" name match



A regression was reported to me recently whereby /dev/fb0 had disappeared
from a PowerBook G3 Series "Wallstreet". The problem shows up when the
"video=ofonly" parameter is passed to the kernel, which is what the
bootloader does when "no video driver" is selected. The cause of the
problem is the "offb" string comparison, which got mangled when it got
refactored. Fix it.

Cc: stable@vger.kernel.org
Fixes: 93604a5a ("fbdev: Handle video= parameter in video/cmdline.c")
Reported-and-tested-by: default avatarStan Johnson <userm57@yahoo.com>
Signed-off-by: default avatarFinn Thain <fthain@linux-m68k.org>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 3637d34b
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -40,7 +40,7 @@ int fb_get_options(const char *name, char **option)
	bool enabled;

	if (name)
		is_of = strncmp(name, "offb", 4);
		is_of = !strncmp(name, "offb", 4);

	enabled = __video_get_options(name, &options, is_of);