Commit 15fc0bec authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba
Browse files

btrfs: make btrfs_cleanup_ordered_extents() support large folios 



When hitting a large folio, btrfs_cleanup_ordered_extents() will get the
same large folio multiple times, and clearing the same range again and
again.

Thankfully this is not causing anything wrong, just inefficiency.

This is caused by the fact that we're iterating folios using the old
page index, thus can hit the same large folio again and again.

Enhance it by increasing @index to the index of the folio end, and only
increase @index by 1 if we failed to grab a folio.

Reviewed-by: default avatarBoris Burkov <boris@bur.io>
Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent ad580dfa

fs/btrfs/inode.c

+4 −2
Original line number Diff line number Diff line
@@ -401,10 +401,12 @@ static inline void btrfs_cleanup_ordered_extents(struct btrfs_inode *inode, 


	while (index <= end_index) {

		folio = filemap_get_folio(inode->vfs_inode.i_mapping, index);

		if (IS_ERR(folio)) {

			index++;

		if (IS_ERR(folio))

			continue;

		}



		index = folio_end(folio) >> PAGE_SHIFT;

		/*

		 * Here we just clear all Ordered bits for every page in the

		 * range, then btrfs_mark_ordered_io_finished() will handle