Commit 15fcedd4 authored by Kees Cook's avatar Kees Cook
Browse files

kexec: Annotate struct crash_mem with __counted_by 

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct crash_mem.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci



Cc: Eric Biederman <ebiederm@xmission.com>
Cc: kexec@lists.infradead.org
Acked-by: default avatarBaoquan He <bhe@redhat.com>
Link: https://lore.kernel.org/r/20230922175224.work.712-kees@kernel.org


Signed-off-by: default avatarKees Cook <keescook@chromium.org>
parent bf5abc17

include/linux/crash_core.h

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ int parse_crashkernel_low(char *cmdline, unsigned long long system_ram, 
struct crash_mem {

	unsigned int max_nr_ranges;

	unsigned int nr_ranges;

	struct range ranges[];

	struct range ranges[] __counted_by(max_nr_ranges);

};



extern int crash_exclude_mem_range(struct crash_mem *mem,