Unverified Commit 1603cbb6 authored by Brian Masney's avatar Brian Masney Committed by Stephen Boyd
Browse files

clk: visconti: pll: initialize clk_init_data to zero 

Sashiko reported the following:

> The struct clk_init_data init is declared on the stack without being
> fully zero-initialized. While fields like name, flags, parent_names,
> num_parents, and ops are explicitly assigned, the parent_data and
> parent_hws fields are left containing stack garbage.

clk_core_populate_parent_map() currently prefers the parent names over
the parent data and hws, so this isn't a problem at the moment. If that
ordering ever changed in the future, then this could lead to some
unexpected crashes. Let's just go ahead and make sure that the struct
clk_init_data is initialized to zero as a good practice.

Fixes: b4cbe606 ("clk: visconti: Add support common clock driver and reset driver")
Link: https://sashiko.dev/#/patchset/20260326042317.122536-1-rosenp%40gmail.com


Signed-off-by: default avatarBrian Masney <bmasney@redhat.com>
Reviewed-by: default avatarBenoît Monin <benoit.monin@bootlin.com>
Reviewed-by: default avatarNobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent f520a492

drivers/clk/visconti/pll.c

+1 −1
Original line number Diff line number Diff line
@@ -249,7 +249,7 @@ static struct clk_hw *visconti_register_pll(struct visconti_pll_provider *ctx, 
					    const struct visconti_pll_rate_table *rate_table,

					    spinlock_t *lock)

{

	struct clk_init_data init;

	struct clk_init_data init = {};

	struct visconti_pll *pll;

	struct clk_hw *pll_hw_clk;

	size_t len;