Commit 16145698 authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Carlos Maiolino
Browse files

xfs: fix xfs_group release bug in xfs_verify_report_losses 



Chris Mason reports that his AI tools noticed that we were using
xfs_perag_put and xfs_group_put to release the group reference returned
by xfs_group_next_range.  However, the iterator function returns an
object with an active refcount, which means that we must use the correct
function to release the active refcount, which is _rele.

Fixes: b8accfd6 ("xfs: add media verification ioctl")
Reported-by: default avatarChris Mason <clm@meta.com>
Link: https://lore.kernel.org/linux-xfs/20260206030527.2506821-1-clm@meta.com/


Signed-off-by: default avatar"Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent e764dd43

fs/xfs/xfs_verify_media.c

+2 −2
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ xfs_verify_report_losses( 


			error = xfs_alloc_read_agf(pag, tp, 0, &agf_bp);

			if (error) {

				xfs_perag_put(pag);

				xfs_perag_rele(pag);

				break;

			}
@@ -158,7 +158,7 @@ xfs_verify_report_losses( 
		if (rtg)

			xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_RMAP);

		if (error) {

			xfs_group_put(xg);

			xfs_group_rele(xg);

			break;

		}

	}