Commit 16274d7e authored by Mukesh Ojha's avatar Mukesh Ojha Committed by Jassi Brar
Browse files

mailbox: qcom-ipcc: Reset CLEAR_ON_RECV_RD if set from boot firmware



For some SoCs, boot firmware is using the same IPCC instance used
by Linux and it has kept CLEAR_ON_RECV_RD set which basically means
interrupt pending registers are cleared when RECV_ID is read and the
register automatically updates to the next pending interrupt/client
status based on priority.

Clear the CLEAR_ON_RECV_RD if it is set from the boot firmware.

Signed-off-by: default avatarMukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Signed-off-by: default avatarJassi Brar <jassisinghbrar@gmail.com>
parent e4b1d67e
Loading
Loading
Loading
Loading
+16 −0
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@
#include <dt-bindings/mailbox/qcom-ipcc.h>

/* IPCC Register offsets */
#define IPCC_REG_CONFIG			0x08
#define IPCC_REG_SEND_ID		0x0c
#define IPCC_REG_RECV_ID		0x10
#define IPCC_REG_RECV_SIGNAL_ENABLE	0x14
@@ -21,6 +22,7 @@
#define IPCC_REG_RECV_SIGNAL_CLEAR	0x1c
#define IPCC_REG_CLIENT_CLEAR		0x38

#define IPCC_CLEAR_ON_RECV_RD		BIT(0)
#define IPCC_SIGNAL_ID_MASK		GENMASK(15, 0)
#define IPCC_CLIENT_ID_MASK		GENMASK(31, 16)

@@ -274,6 +276,7 @@ static int qcom_ipcc_pm_resume(struct device *dev)
static int qcom_ipcc_probe(struct platform_device *pdev)
{
	struct qcom_ipcc *ipcc;
	u32 config_value;
	static int id;
	char *name;
	int ret;
@@ -288,6 +291,19 @@ static int qcom_ipcc_probe(struct platform_device *pdev)
	if (IS_ERR(ipcc->base))
		return PTR_ERR(ipcc->base);

	/*
	 * It is possible that boot firmware is using the same IPCC instance
	 * as of the HLOS and it has kept CLEAR_ON_RECV_RD set which basically
	 * means Interrupt pending registers are cleared when RECV_ID is read.
	 * The register automatically updates to the next pending interrupt/client
	 * status based on priority.
	 */
	config_value = readl(ipcc->base + IPCC_REG_CONFIG);
	if (config_value & IPCC_CLEAR_ON_RECV_RD) {
		config_value &= ~(IPCC_CLEAR_ON_RECV_RD);
		writel(config_value, ipcc->base + IPCC_REG_CONFIG);
	}

	ipcc->irq = platform_get_irq(pdev, 0);
	if (ipcc->irq < 0)
		return ipcc->irq;