Commit 1631cbdb authored by Diederik de Haas's avatar Diederik de Haas Committed by Heiko Stuebner
Browse files

arm64: dts: rockchip: Improve LED config for NanoPi R5S 



The NanoPi R5S has 4 GPIO LEDs, a RED one for SYStem power and 3 green
LEDs meant to indicate that a cable is connected to either of the
2.5GbE LAN ports or the 1GbE WAN port.

In the NanoPi R5S schematic (2204; page 19) as well as on the PCB and on
the case, SYS is used and not POWER. So replace 'power' with 'sys'.
But keep the 'power_led' label/phandle even though the kernel doesn't
use it, but it may be used outside of it.

The SYStem LED already had "heartbeat" as its default-trigger.
Set the default-trigger to "netdev" for the NICs so they will show when
LAN1/LAN2/WAN is connected and set their default-state to "off".

Also assign labels as close as possible to the labels on the case, while
still being descriptive enough in their own right.

Signed-off-by: default avatarDiederik de Haas <didi.debian@cknow.org>
Link: https://lore.kernel.org/r/20250513170056.96259-1-didi.debian@cknow.org


Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 56198acd

arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts

+14 −4
Original line number Diff line number Diff line
@@ -20,33 +20,43 @@ aliases { 
	gpio-leds {

		compatible = "gpio-leds";

		pinctrl-names = "default";

		pinctrl-0 = <&lan1_led_pin>, <&lan2_led_pin>, <&power_led_pin>, <&wan_led_pin>;

		pinctrl-0 = <&lan1_led_pin>, <&lan2_led_pin>, <&sys_led_pin>, <&wan_led_pin>;



		led-lan1 {

			color = <LED_COLOR_ID_GREEN>;

			default-state = "off";

			function = LED_FUNCTION_LAN;

			function-enumerator = <1>;

			gpios = <&gpio3 RK_PD6 GPIO_ACTIVE_HIGH>;

			label = "LAN-1";

			linux,default-trigger = "netdev";

		};



		led-lan2 {

			color = <LED_COLOR_ID_GREEN>;

			default-state = "off";

			function = LED_FUNCTION_LAN;

			function-enumerator = <2>;

			gpios = <&gpio3 RK_PD7 GPIO_ACTIVE_HIGH>;

			label = "LAN-2";

			linux,default-trigger = "netdev";

		};



		power_led: led-power {

		power_led: led-sys {

			color = <LED_COLOR_ID_RED>;

			function = LED_FUNCTION_POWER;

			linux,default-trigger = "heartbeat";

			gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>;

			label = "SYS";

			linux,default-trigger = "heartbeat";

		};



		led-wan {

			color = <LED_COLOR_ID_GREEN>;

			default-state = "off";

			function = LED_FUNCTION_WAN;

			gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;

			label = "WAN";

			linux,default-trigger = "netdev";

		};

	};

};
@@ -126,7 +136,7 @@ lan2_led_pin: lan2-led-pin { 
			rockchip,pins = <3 RK_PD7 RK_FUNC_GPIO &pcfg_pull_none>;

		};



		power_led_pin: power-led-pin {

		sys_led_pin: sys-led-pin {

			rockchip,pins = <4 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;

		};