Unverified Commit 163a68a3 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Ilpo Järvinen
Browse files

platform/x86: intel/rst: Convert ACPI driver to a platform one 

In all cases in which a struct acpi_driver is used for binding a driver
to an ACPI device object, a corresponding platform device is created by
the ACPI core and that device is regarded as a proper representation of
underlying hardware.  Accordingly, a struct platform_driver should be
used by driver code to bind to that device.  There are multiple reasons
why drivers should not bind directly to ACPI device objects [1].

Overall, it is better to bind drivers to platform devices than to their
ACPI companions, so convert the Intel Rapid Start Technology (rst) ACPI
driver to a platform one.

While this is not expected to alter functionality, it changes sysfs
layout and so it will be visible to user space.

Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/

 [1]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/3599223.QJadu78ljV@rafael.j.wysocki


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 079b59fd

drivers/platform/x86/intel/rst.c

+13 −10
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 


#include <linux/acpi.h>

#include <linux/module.h>

#include <linux/platform_device.h>

#include <linux/slab.h>



MODULE_DESCRIPTION("Intel Rapid Start Technology Driver");
@@ -99,8 +100,9 @@ static struct device_attribute irst_timeout_attr = { 
	.store = irst_store_wakeup_time

};



static int irst_add(struct acpi_device *acpi)

static int irst_probe(struct platform_device *pdev)

{

	struct acpi_device *acpi = ACPI_COMPANION(&pdev->dev);

	int error;



	error = device_create_file(&acpi->dev, &irst_timeout_attr);
@@ -114,8 +116,10 @@ static int irst_add(struct acpi_device *acpi) 
	return error;

}



static void irst_remove(struct acpi_device *acpi)

static void irst_remove(struct platform_device *pdev)

{

	struct acpi_device *acpi = ACPI_COMPANION(&pdev->dev);



	device_remove_file(&acpi->dev, &irst_wakeup_attr);

	device_remove_file(&acpi->dev, &irst_timeout_attr);

}
@@ -125,16 +129,15 @@ static const struct acpi_device_id irst_ids[] = { 
	{"", 0}

};



static struct acpi_driver irst_driver = {

	.name = "intel_rapid_start",

	.class = "intel_rapid_start",

	.ids = irst_ids,

	.ops = {

		.add = irst_add,

static struct platform_driver irst_driver = {

	.probe = irst_probe,

	.remove = irst_remove,

	.driver = {

		.name = "intel_rapid_start",

		.acpi_match_table = irst_ids,

	},

};



module_acpi_driver(irst_driver);

module_platform_driver(irst_driver);



MODULE_DEVICE_TABLE(acpi, irst_ids);