Commit 164c187d authored by Alok Tiwari's avatar Alok Tiwari Committed by Christoph Hellwig
Browse files

nvme: fix multiple spelling and grammar issues in host drivers 



This commit fixes several typos and grammatical issues across various
nvme host driver files:

 - correct "glace" to "glance" in a comment in apple.c
 - fix "Idependent" to "Independent" in core.c
 - change "unsucceesful" to "unsuccessful", "they blk-mq" to "the blk-mq",
 - fix "terminaed" to "terminated" and other grammar in fc.c
 - update "O's" to "0's" to clarify meaning in nvme.h
 - fix a function name reference in a comment in zns.c:
   *_transter_len() -> *_transfer_len().
 - fix sysfs_emit() output format in pci.c (replace x%08x with 0x%08x)

These changes improve the code readability and documentation consistency
across the NVMe driver.

Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent ab17ead0

drivers/nvme/host/apple.c

+2 −2
Original line number Diff line number Diff line
@@ -301,8 +301,8 @@ static void apple_nvme_submit_cmd(struct apple_nvme_queue *q, 
	memcpy(&q->sqes[tag], cmd, sizeof(*cmd));



	/*

	 * This lock here doesn't make much sense at a first glace but

	 * removing it will result in occasional missed completetion

	 * This lock here doesn't make much sense at a first glance but

	 * removing it will result in occasional missed completion

	 * interrupts even though the commands still appear on the CQ.

	 * It's unclear why this happens but our best guess is that

	 * there is a bug in the firmware triggered when a new command

drivers/nvme/host/core.c

+1 −1
Original line number Diff line number Diff line
@@ -4286,7 +4286,7 @@ static void nvme_scan_ns(struct nvme_ctrl *ctrl, unsigned nsid) 
	}



	/*

	 * If available try to use the Command Set Idependent Identify Namespace

	 * If available try to use the Command Set Independent Identify Namespace

	 * data structure to find all the generic information that is needed to

	 * set up a namespace.  If not fall back to the legacy version.

	 */

drivers/nvme/host/fc.c

+5 −5
Original line number Diff line number Diff line
@@ -899,7 +899,7 @@ EXPORT_SYMBOL_GPL(nvme_fc_set_remoteport_devloss); 
 * may crash.

 *

 * As such:

 * Wrapper all the dma routines and check the dev pointer.

 * Wrap all the dma routines and check the dev pointer.

 *

 * If simple mappings (return just a dma address, we'll noop them,

 * returning a dma address of 0.
@@ -1955,8 +1955,8 @@ nvme_fc_fcpio_done(struct nvmefc_fcp_req *req) 
	}



	/*

	 * For the linux implementation, if we have an unsucceesful

	 * status, they blk-mq layer can typically be called with the

	 * For the linux implementation, if we have an unsuccessful

	 * status, the blk-mq layer can typically be called with the

	 * non-zero status and the content of the cqe isn't important.

	 */

	if (status)
@@ -2429,7 +2429,7 @@ static bool nvme_fc_terminate_exchange(struct request *req, void *data) 


/*

 * This routine runs through all outstanding commands on the association

 * and aborts them.  This routine is typically be called by the

 * and aborts them.  This routine is typically called by the

 * delete_association routine. It is also called due to an error during

 * reconnect. In that scenario, it is most likely a command that initializes

 * the controller, including fabric Connect commands on io queues, that
@@ -2622,7 +2622,7 @@ nvme_fc_unmap_data(struct nvme_fc_ctrl *ctrl, struct request *rq, 
 * as part of the exchange.  The CQE is the last thing for the io,

 * which is transferred (explicitly or implicitly) with the RSP IU

 * sent on the exchange. After the CQE is received, the FC exchange is

 * terminaed and the Exchange may be used on a different io.

 * terminated and the Exchange may be used on a different io.

 *

 * The transport to LLDD api has the transport making a request for a

 * new fcp io request to the LLDD. The LLDD then allocates a FC exchange

drivers/nvme/host/nvme.h

+1 −1
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ enum nvme_quirks { 
	NVME_QUIRK_IDENTIFY_CNS			= (1 << 1),



	/*

	 * The controller deterministically returns O's on reads to

	 * The controller deterministically returns 0's on reads to

	 * logical blocks that deallocate was called on.

	 */

	NVME_QUIRK_DEALLOCATE_ZEROES		= (1 << 2),

drivers/nvme/host/pci.c

+1 −1
Original line number Diff line number Diff line
@@ -2439,7 +2439,7 @@ static ssize_t cmb_show(struct device *dev, struct device_attribute *attr, 
{

	struct nvme_dev *ndev = to_nvme_dev(dev_get_drvdata(dev));



	return sysfs_emit(buf, "cmbloc : x%08x\ncmbsz  : x%08x\n",

	return sysfs_emit(buf, "cmbloc : 0x%08x\ncmbsz  : 0x%08x\n",

		       ndev->cmbloc, ndev->cmbsz);

}

static DEVICE_ATTR_RO(cmb);